Update @firebase/template to move tests next to source files #2875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsubox76
reviewed
Apr 7, 2020
| @@ -57,7 +57,10 @@ const config = { | |||
| // preprocess matching files before serving them to the browser | |||
| // available preprocessors: | |||
| // https://npmjs.org/browse/keyword/karma-preprocessor | |||
| preprocessors: { 'test/**/*.ts': ['webpack', 'sourcemap'] }, | |||
| preprocessors: { | |||
| 'test/**/*.ts': ['webpack', 'sourcemap'], | |||
There was a problem hiding this comment.
Should we get rid of this pattern since template doesn't have a test/ dir anymore?
There was a problem hiding this comment.
This config file is shared with packages that still have tests in the test/ dir, so we need to keep it for now.
hsubox76
approved these changes
Apr 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.