Discourage use of 'window' and 'document' #2874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilhuff
reviewed
Apr 6, 2020
| return typeof document !== 'undefined' ? document : null; | ||
| } | ||
|
|
||
| get window(): Window | null { | ||
| // `window` is not always available, e.g. in ReactNative and WebWorkers. |
There was a problem hiding this comment.
Drive-by comment: should this fall back on self in a web worker?
There was a problem hiding this comment.
I don't know and we should be careful if we want to make this change. FWIW, this doc says to always use self: https://developer.mozilla.org/en-US/docs/Web/API/Window/self
This works because JS in browsers prefixes any unknown globals with window and window.self seems to be a thing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help us find issues such as #2870 before they surface in ReactNative and WebWorkers.