Skip to content

Remove Platform.useProto3Json flag #2866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 20, 2020
Merged

Remove Platform.useProto3Json flag #2866

merged 3 commits into from
Apr 20, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Apr 3, 2020 •
edited
Loading

In the field value rewrite, I added a Platform.useProto3Json flag. I just realized we don't need it since we have newSerializer().

@schmidt-sebastian
Remove Platform.useProto3Json flag
12c7563 
In the field value rewrite, I added a Platform.useProto3Json flag. I just realized we don't need it since we have .
@schmidt-sebastian schmidt-sebastian requested a review from wu-hui April 3, 2020 22:23
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 3, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (537350e) Head (f40cf81) Diff
    browser 253 kB 253 kB -7 B (-0.0%)
    esm2017 200 kB 200 kB -1 B (-0.0%)
    main 487 kB 487 kB -116 B (-0.0%)
    module 251 kB 251 kB -7 B (-0.0%)

  • @firebase/firestore/memory

    Type Base (537350e) Head (f40cf81) Diff
    browser 200 kB 200 kB -7 B (-0.0%)
    esm2017 156 kB 156 kB -1 B (-0.0%)
    main 377 kB 377 kB -116 B (-0.0%)
    module 198 kB 198 kB -7 B (-0.0%)

  • firebase

    Type Base (537350e) Head (f40cf81) Diff
    firebase-firestore.js 295 kB 295 kB -7 B (-0.0%)
    firebase-firestore.memory.js 243 kB 243 kB -7 B (-0.0%)
    firebase.js 828 kB 828 kB -7 B (-0.0%)

Test Logs

wu-hui
wu-hui approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmidt-sebastian schmidt-sebastian merged commit 1562bb7 into master Apr 20, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/proto3flag branch April 20, 2020 19:39
@firebase firebase locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@wu-hui wu-hui

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @wu-hui