Skip to content

Initial submit of auth-next framework #2851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 3, 2020
Merged

Initial submit of auth-next framework #2851

merged 6 commits into from
Apr 3, 2020

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Apr 1, 2020

This is for the most part copied directly from packages/template, but I've installed a bunch of stuff in package.json to get the tests to run correctly

@sam-gc sam-gc requested review from avolkovi and Feiyang1 April 1, 2020 21:23
@sam-gc sam-gc removed request for hiranya911 and hsubox76 April 1, 2020 21:23
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 1, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

SDKTypeBase (d9b599f)Head (b47675c)Diff
Metric Unit: byte

Test Logs

Feiyang1
Feiyang1 reviewed Apr 2, 2020
View reviewed changes
Copy link
Member

@Feiyang1 Feiyang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can remove most of the devDependencies since we manage them in the root package.json.
Also the peerDependencies should point to @firebase/app-exp and @firebase/app-types-exp. Otherwise, it looks great!

@Feiyang1
Copy link
Member

Feiyang1 commented Apr 2, 2020

We are also moving toward keeping test files and source files in the same folder following the g3 style guide.
I'm using this structure in @firebase/app-exp and a few existing packages are already using it - e.g. @firebase/installations, @firebase/analytics

@Feiyang1 Feiyang1 removed their assignment Apr 2, 2020
avolkovi
avolkovi approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@avolkovi avolkovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly nits

@sam-gc sam-gc merged commit 087f8e2 into auth-next Apr 3, 2020
avolkovi pushed a commit that referenced this pull request Apr 22, 2020
@sam-gc @avolkovi
Initial submit of auth-next framework (#2851)
1894143 
Initial package structure--copied from packages/template, but with tests working
avolkovi pushed a commit that referenced this pull request Apr 23, 2020
@sam-gc @avolkovi
Initial submit of auth-next framework (#2851)
4996eaf 
Initial package structure--copied from packages/template, but with tests working
avolkovi pushed a commit that referenced this pull request Apr 24, 2020
@sam-gc @avolkovi
Initial submit of auth-next framework (#2851)
b230b1b 
Initial package structure--copied from packages/template, but with tests working
@firebase firebase locked and limited conversation to collaborators May 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 left review comments

@avolkovi avolkovi avolkovi approved these changes

Assignees

@avolkovi avolkovi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sam-gc @google-oss-bot @Feiyang1 @avolkovi