Skip to content

Disable health-metrics test in pull requests from forked repo. #2819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

yifanyang
Copy link
Contributor

Health metrics tests use secrets in this repo to work properly. However, secrets are not available in workflows triggered by pull requests from forked repo, therefore the metrics tests will always fail there. Disabling it to avoid leaving a failure mark on those pull requests.

https://help.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets#using-encrypted-secrets-in-a-workflow

@google-oss-bot
Copy link
Contributor

@yifanyang yifanyang merged commit 049118a into master Mar 30, 2020
@yifanyang yifanyang deleted the yifany/fix branch March 30, 2020 17:53
@firebase firebase locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants