Remove asserts

packages/firestore/rollup.config.js

@@ -29,7 +29,7 @@ import pkg from './package.json';
 import memoryPkg from './memory/package.json';
 
 import {
-  appendPrivatePrefixTransformers,
+  firestoreTransformers,
   manglePrivatePropertiesOptions
 } from './terser.config';
 
@@ -102,7 +102,7 @@ export function resolveMemoryExterns(deps, externsId, referencedBy) {
 const es5BuildPlugins = [
   typescriptPlugin({
     typescript,
-    transformers: appendPrivatePrefixTransformers,
+    transformers: firestoreTransformers,
     cacheRoot: `./.cache/es5.mangled/`
   }),
   json(),
@@ -118,7 +118,7 @@ const es2017BuildPlugins = [
       }
     },
     cacheRoot: './.cache/es2017.mangled/',
-    transformers: appendPrivatePrefixTransformers
+    transformers: firestoreTransformers
   }),
   json({ preferConst: true }),
   terser(manglePrivatePropertiesOptions)

packages/firestore/scripts/remove-asserts.ts

@@ -0,0 +1,56 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+import * as ts from 'typescript';
+
+// Location of file that includes the asserts
+const DECLARING_FILE = "packages/firestore/src/util/assert.ts";
+
+export function removeAsserts(
+  program: ts.Program
+): ts.TransformerFactory<ts.SourceFile> {
+  const removeAsserts = new RemoveAsserts(program.getTypeChecker());
+  return (context: ts.TransformationContext) => (file: ts.SourceFile) => {
+    return removeAsserts.visitNodeAndChildren(file, context);
+  };
+}
+
+/** Transformer that removes all "asserts" and "fail" statement from the SDK. */
+class RemoveAsserts {
+  constructor(
+    private readonly typeChecker: ts.TypeChecker,
+  ) {}
+
+  visitNodeAndChildren<T extends ts.Node>(
+    node: T,
+    context: ts.TransformationContext
+  ): T {
+    return ts.visitEachChild(
+      this.visitNode(node),
+      (childNode: ts.Node) => this.visitNodeAndChildren(childNode, context),
+      context
+    ) as T;
+  }
+
+  visitNode(node: ts.Node): ts.Node {
+    if (ts.isCallExpression(node)) {
+      const signature = this.typeChecker.getResolvedSignature(node);
+      if (signature && signature.declaration &&
+        signature.declaration.kind === ts.SyntaxKind.FunctionDeclaration) {
+        const declaration = signature.declaration as ts.FunctionDeclaration;
+        if(declaration && declaration.getSourceFile().fileName.indexOf(
+          DECLARING_FILE) >= 0) {
+          const method = declaration.name!.text;
+          if (method === 'assert') {
+            return ts.createEmptyStatement();
+          } else if (method === 'fail') {
+            if (node.parent.kind === ts.SyntaxKind.ExpressionStatement) {
+              return ts.createEmptyStatement();
+            } else {
+              return ts.updateCall(node, node.expression, [], []);
+            }
+          }
+        }
+      }
+    }
+    return node;
+  }
+}

packages/firestore/src/core/view.ts

@@ -389,12 +389,12 @@ export class View {
       targetChange.addedDocuments.forEach(
         key => (this._syncedDocuments = this._syncedDocuments.add(key))
       );
-      targetChange.modifiedDocuments.forEach(key =>
+      targetChange.modifiedDocuments.forEach(key => {
         assert(
           this._syncedDocuments.has(key),
           `Modified document ${key} not found in view.`
-        )
-      );
+        );
+      });
       targetChange.removedDocuments.forEach(
         key => (this._syncedDocuments = this._syncedDocuments.delete(key))
       );

packages/firestore/terser.config.js

@@ -20,16 +20,19 @@ import * as path from 'path';
 import { externs } from './externs.json';
 import { renameInternals } from './scripts/rename-internals';
 import { extractPublicIdentifiers } from './scripts/extract-api';
+import { removeAsserts } from './scripts/remove-asserts';
 
 const externsPaths = externs.map(p => path.resolve(__dirname, '../../', p));
 const publicIdentifiers = extractPublicIdentifiers(externsPaths);
 
 /**
- * A transformer that appends a __PRIVATE_ prefix to all internal symbols.
+ * Transformers that remove all asserts and appends a __PRIVATE_ prefix to
+ * all internal symbols.
  */
-export const appendPrivatePrefixTransformers = [
+export const firestoreTransformers = [
   service => ({
     before: [
+      removeAsserts(service.getProgram()),
       renameInternals(service.getProgram(), {
         publicIdentifiers,
         prefix: '__PRIVATE_'