Skip to content

Fix onLog type in public API to be compatible with Typescript <3.x #2789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2020

Conversation

hsubox76
Copy link
Contributor

Fix #2780. Typescript <3.x does not recognize unknown.

@hsubox76 hsubox76 requested a review from egilmorez as a code owner March 24, 2020 01:03
@hsubox76 hsubox76 requested a review from Feiyang1 March 24, 2020 17:24
@hsubox76 hsubox76 merged commit 1de36ed into master Mar 24, 2020
@hsubox76 hsubox76 deleted the ch-typefix branch April 3, 2020 18:54
@firebase firebase locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR in node_modules/firebase/index.d.ts(134,13): error TS2304: Cannot find name 'unknown'.
2 participants