size presubmit check #2720
Closed
size presubmit check #2720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifanyang
reviewed
Mar 6, 2020
|
|
||
| const repoRoot = resolve(__dirname, '..'); | ||
|
|
||
| const commitHash = process.env.GITHUB_SHA || execSync('git rev-parse HEAD').toString(); |
There was a problem hiding this comment.
We seem to use simple-git for git operations in other places in this repo.
I'm okay with both. Will leave it up to you whether we want to pursue any consistency.
yifanyang
reviewed
Mar 6, 2020
scripts/report_binary_size.js
Outdated
Comment on lines
29
to
30
| const fileName = file.split('/').slice(-1)[0] | ||
| reports.push(makeReportObject('firebase', fileName, size)) |
There was a problem hiding this comment.
Suggested change
| const fileName = file.split('/').slice(-1)[0] | |
| reports.push(makeReportObject('firebase', fileName, size)) | |
| const fileName = file.split('/').slice(-1)[0]; | |
| reports.push(makeReportObject('firebase', fileName, size)); |
yifanyang
reviewed
Mar 6, 2020
scripts/report_binary_size.js
Outdated
| return reports; | ||
| } | ||
|
|
||
| // @firebase/* |
There was a problem hiding this comment.
Suggested change
| // @firebase/* | |
| // NPM packages |
yifanyang
reviewed
Mar 6, 2020
scripts/report_binary_size.js
Outdated
| } | ||
|
|
||
| return { | ||
| log: "https://www.goog.com", |
There was a problem hiding this comment.
I guess this is only applicable to CI runs. So maybe we want to configure it to be some value when on CI and empty when running locally.
Or we can leave this field empty. The only use of this field is to provide a link on the PR comment for developers to examine the original log (when they are surprised by the number.)
There was a problem hiding this comment.
updated to report github action url.
yifanyang
reviewed
Mar 6, 2020
yifanyang
reviewed
Mar 6, 2020
hsubox76
approved these changes
Mar 7, 2020
yifanyang
approved these changes
Mar 10, 2020
|
replaced by #2744 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.