Skip to content

Finish FieldValue migration #2715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

schmidt-sebastian
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@schmidt-sebastian schmidt-sebastian changed the base branch from mrschmidt/rewritefieldvalue-10 to mrschmidt/rewritefieldvalue March 14, 2020 23:52
@schmidt-sebastian schmidt-sebastian changed the base branch from mrschmidt/rewritefieldvalue to master March 16, 2020 04:24
@schmidt-sebastian schmidt-sebastian changed the base branch from master to mrschmidt/rewritefieldvalue March 16, 2020 04:26
@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/rewritefieldvalue-11 branch from f1dee40 to 723552f Compare March 17, 2020 01:17
@schmidt-sebastian schmidt-sebastian changed the title Mrschmidt/rewritefieldvalue 11 Finish FieldValue migration Mar 17, 2020
@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/rewritefieldvalue-11 branch from 04c4837 to 5a5fe8f Compare March 19, 2020 00:39
@schmidt-sebastian schmidt-sebastian changed the base branch from mrschmidt/rewritefieldvalue to mrschmidt/moveprotofieldvalue March 19, 2020 00:39
@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/rewritefieldvalue-11 branch 3 times, most recently from 8209d30 to 82e1be3 Compare March 19, 2020 21:11
@schmidt-sebastian schmidt-sebastian changed the base branch from mrschmidt/moveprotofieldvalue to master March 19, 2020 21:12
@schmidt-sebastian schmidt-sebastian changed the base branch from master to mrschmidt/moveprotofieldvalue March 19, 2020 21:12
@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/rewritefieldvalue-11 branch from 82e1be3 to 7ad0420 Compare March 19, 2020 22:18
@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/rewritefieldvalue-11 branch from 7ad0420 to b6a60a3 Compare March 19, 2020 22:19
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/rewritefieldvalue-11 branch March 26, 2020 03:05
@firebase firebase locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant