Instrument Repo for Code Coverage #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshcrowthe
requested review from
mikelehen,
schmidt-sebastian and
wilhuff
as code owners
jshcrowthe
assigned mikelehen, wilhuff, schmidt-sebastian, gauntface, bojeil-google and sphippen
|
Approved for RTDB. Got the coverage numbers that I needed. Thanks! |
schmidt-sebastian
approved these changes
Nov 14, 2017
wilhuff
approved these changes
Nov 15, 2017
| @@ -27,9 +27,18 @@ module.exports = { | |||
| use: 'ts-loader' | |||
| }, | |||
| { | |||
| test: /\.js$/, | |||
| use: ['source-map-loader'], | |||
| test: /\.[tj]sx?$/, | |||
There was a problem hiding this comment.
Is this just a standard configuration now or are we really doing jsx and tsx stuff? In contrast in other locations we're still using just straight .ts file extensions.
There was a problem hiding this comment.
It's just a standard thing, we have no need for jsx/tsx so it isn't that big of a deal I don't think.
gauntface
approved these changes
Nov 15, 2017
mikelehen
approved these changes
Nov 16, 2017
|
FYI- It seems like you upgraded prettier in this PR, which caused a bunch of extra formatting changes, which is causing me merge conflicts in a different branch. Going forward it would be helpful if:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to probably take a little extra time (we have to get the extra CI integration approved) but having this instrumented will give us a path to improving our coverage.
Instrumenting files
Browser
All of our browser builds running through
karma-webpackare instrumented viaistanbul-instrumenter-loader. We then dump this info for each component into the componentcoverage/browserdir by browser.Node
All of our node builds are instrumented via
nycwhich is a tool provided by the istanbul folks. Unfortunately, karma is not supported in the same way so we needed two tools. Coverage for this tool is dumped in thecoverage/nodedirectory.Merging
lcov.infoFilesAfter collecting
lcov.infofiles (i.e. the coverage reports) for each file we leveragelcov-result-mergerto consolidate to a single file that we can then pipe to CI.I am going to leave the CI integration (i.e.
coveralls) in as @vikrum is currently evaluating if we can get access here.