De-mangle Node and CJS build #2658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
force-pushed
the
mrschmidt/node
branch
from
d596caf to
83a3924
Compare
Feiyang1
reviewed
Feb 21, 2020
| * Browser Builds | ||
| * Browser CJS Build | ||
| * | ||
| * The Browser CJS build is not mangled as Terser's property name mangling |
There was a problem hiding this comment.
Is CJS format the root of the issue? I thought only the Node build is affected.
There was a problem hiding this comment.
The CJS build that we published contains a bunch of variables prefixed with _PRIVATE, which are not renamed by Terser. As such, the file is bigger than before.
firebase-firestore.js uses the ESM build, before converting to CJS, which means it is not affected.
Feiyang1
approved these changes
Feb 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the mangling from the Node Firestore build, which is probably not as sensitive to size. The actual fix for Node is to just add externs for
GRPCandgrpcloader, but at this point I am kind of wary of doing this as we have no integration tests for the mangled Node build.I also disabled Terser's whitespace and comment removal, since this was previously not applied to NPM builds.
Fixes #2655