Skip to content

Remove Closure build #2646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Remove Closure build #2646

merged 1 commit into from
Feb 28, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

I have a feeling this is not used.

Removing this simplifies my Memory-only Firestore development.

Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be used when exposed in google3. Please double-check.

@schmidt-sebastian
Copy link
Contributor Author

This may be used when exposed in google3. Please double-check.

I checked but also didn't see any references. FWIW, I created a dummy CL that removes it in Google3 and didn't see any issues: https://critique.corp.google.com/#review/296099840

Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned schmidt-sebastian and unassigned wilhuff Feb 28, 2020
@schmidt-sebastian schmidt-sebastian merged commit 6fdc6e1 into master Feb 28, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/standalone branch February 28, 2020 22:40
@firebase firebase locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants