Skip to content

Disable use of $httpHeaders in Cordova #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 13, 2020
Merged

Disable use of $httpHeaders in Cordova #2626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbfc207
check for cordova
Feb 13, 2020
13c04b1
Merge branch 'master' into bc/cordova
Feb 13, 2020
8f36b70
add changelog
Feb 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/firestore/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
# Unreleased
- [fixed] Fixed an issue where auth credentials were not respected in Cordova
environments (#2626).
- [fixed] Fixed a performance regression introduced by the addition of
`Query.limitToLast(n: number)` in Firestore 1.7.0 (Firebase 7.3.0) (#2620).
- [fixed] Fixed an issue where `CollectionReference.add()` would reject
custom types when using `withConverter()`. (#2606)
custom types when using `withConverter()` (#2606).

# 1.9.3
- [fixed] Fixed an issue where auth credentials were not respected in some
Expand Down
2 changes: 2 additions & 0 deletions packages/firestore/src/platform_browser/webchannel_connection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import {
isBrowserExtension,
isElectron,
isIE,
isMobileCordova,
isReactNative,
isUWP
} from '@firebase/util';
Expand Down Expand Up @@ -275,6 +276,7 @@ export class WebChannelConnection implements Connection {
// known to (sometimes) not include an Origin. See
// https://github.com/firebase/firebase-js-sdk/issues/1491.
if (
!isMobileCordova() &&
!isReactNative() &&
!isElectron() &&
!isIE() &&
Expand Down