Improve logic for detecting what PR tests to run #2615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feiyang1
suggested changes
Feb 11, 2020
| // Add the package itself. | ||
| changedPackages[match[1]] = 'direct'; | ||
| // Add packages that depend on it. | ||
| for (const package in depGraph) { |
There was a problem hiding this comment.
Shouldn't we run tests for depending packages even if changedPackage.scripts.test evaluates to false? something like:
if (changedPackage) {
if (changedPackage.scripts.test) {
changedPackages[match[1]] = 'direct';
}
for (const package in depGraph) {
...
}
}
Feiyang1
approved these changes
Feb 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds detection of other tests that should run: