-
Notifications
You must be signed in to change notification settings - Fork 940
Memory-only Firestore build #2608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
860b649
RFC: Memory-only Firestore build
schmidt-sebastian a4a8856
Merge
schmidt-sebastian 2080ba8
Review feedback
schmidt-sebastian 0ed63b3
Merge
schmidt-sebastian af52293
Revert Object.assign changes
schmidt-sebastian 7121065
Update index.memory.ts
schmidt-sebastian 34c6f64
Merge
schmidt-sebastian cce2ddd
Lint fix
schmidt-sebastian 9b4ef91
Fix output name
schmidt-sebastian 5d61740
Merge branch 'master' into mrschmidt/memorybuild
schmidt-sebastian 9544744
Use resolveMemoryExterns
schmidt-sebastian e4a596c
Merge
schmidt-sebastian df0b87c
Update to expose as @firebase/firestore/memory
schmidt-sebastian 09276a7
Prettier
schmidt-sebastian 2ac9dfc
Add firebase/firestore/memory
schmidt-sebastian ce47ef8
Restructure Rollup config
schmidt-sebastian 37e1f0f
Update test configuration
schmidt-sebastian 2a8e78a
Use composition
schmidt-sebastian de25f91
Cleanup
schmidt-sebastian 07ff26e
Lint
schmidt-sebastian 6a6ec47
Cleanup
schmidt-sebastian 53a4d12
Merge
schmidt-sebastian df6a633
Update rollup.config.js
schmidt-sebastian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
/** | ||
* @license | ||
* Copyright 2020 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import '../../firestore/dist/index.memory.esm'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/** | ||
* @license | ||
* Copyright 2020 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import firebase from '@firebase/app'; | ||
import * as types from '@firebase/firestore-types'; | ||
import { FirebaseNamespace } from '@firebase/app-types'; | ||
|
||
import { configureForFirebase } from './src/platform/config'; | ||
import './register-module'; | ||
import './src/platform_browser/browser_init'; | ||
|
||
import { name, version } from './package.json'; | ||
import {Firestore, PublicMemoryFirestore} from "./src/api/database"; | ||
|
||
export function registerFirestore(instance: FirebaseNamespace): void { | ||
configureForFirebase(instance, PublicMemoryFirestore, Firestore); | ||
instance.registerVersion(name, version); | ||
} | ||
|
||
registerFirestore(firebase); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/** | ||
* @license | ||
* Copyright 2020 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import firebase from '@firebase/app'; | ||
import { FirebaseNamespace } from '@firebase/app-types'; | ||
|
||
import { configureForFirebase } from './src/platform/config'; | ||
import './register-module'; | ||
import './src/platform_node/node_init'; | ||
|
||
import { name, version } from './package.json'; | ||
import {Firestore, PublicMemoryFirestore} from "./src/api/database"; | ||
|
||
export function registerFirestore(instance: FirebaseNamespace): void { | ||
configureForFirebase(instance, PublicMemoryFirestore, Firestore); | ||
instance.registerVersion(name, version); | ||
} | ||
|
||
registerFirestore(firebase); | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done (here and elsewhere)