Ignore primary lease loss in maybeGarbageCollectMultiClientState #2585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ignores the error if the primary lease is somehow lost between updateClientMetadataAndTryBecomePrimary() and maybeGarbageCollectMultiClientState(). There is no special recovery logic needed as the next primary will run the periodic GC. Fixes #2555
wu-hui
reviewed
Jan 31, 2020
| @@ -489,7 +488,12 @@ export class IndexedDbPersistence implements Persistence { | |||
| ).next(() => inactive); | |||
| }); | |||
| } | |||
| ); | |||
| ).catch(() => { | |||
| // Ignore primary lease violations or any other type of error. | |||
There was a problem hiding this comment.
I think it's worth adding why it's OK to ignore all the errors here.
Something along the line where you put in PR description: There is no special recovery logic needed as the next primary will run the periodic GC.
wu-hui
approved these changes
Jan 31, 2020
|
@wilhuff for approval |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ignores the error if the primary lease is somehow lost between updateClientMetadataAndTryBecomePrimary() and maybeGarbageCollectMultiClientState(). There is no special recovery logic needed as the next primary will run the periodic GC.
Fixes #2555