-
Notifications
You must be signed in to change notification settings - Fork 942
Run tests only on changed packages on PR/push #2565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 8 commits
7fc2507
104f265
03744a1
df2ae48
d7bf6f6
52da8de
9f52d00
d308bab
06acd8f
6d28a60
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
name: Push/PR | ||
|
||
on: [push, pull_request] | ||
|
||
jobs: | ||
test: | ||
name: Test Packages With Changed Files | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v1 | ||
- name: Set up Node (10) | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: 10.x | ||
- name: Test setup and yarn install | ||
run: | | ||
cp config/ci.config.json config/project.json | ||
yarn | ||
- name: yarn build | ||
run: yarn build | ||
- name: Run tests on changed packages | ||
run: xvfb-run yarn test:changed |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,83 @@ | ||
/** | ||
* @license | ||
* Copyright 2019 Google Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
const { resolve } = require('path'); | ||
const { spawn } = require('child-process-promise'); | ||
const simpleGit = require('simple-git/promise'); | ||
const root = resolve(__dirname, '..'); | ||
const git = simpleGit(root); | ||
|
||
/** | ||
* Runs tests on packages changed (in comparison to origin/master...HEAD) | ||
*/ | ||
|
||
async function runTestsOnChangedPackages() { | ||
const diff = await git.diff(['--name-only', 'origin/master...HEAD']); | ||
const changedFiles = diff.split('\n'); | ||
const changedPackages = {}; | ||
for (const filename of changedFiles) { | ||
const match = filename.match('^(packages/[a-zA-Z0-9-]+)/.*'); | ||
if (match && match[1]) { | ||
const pkg = require(resolve(root, match[1], 'package.json')); | ||
if (pkg && pkg.scripts.test) { | ||
changedPackages[match[1]] = true; | ||
} | ||
} | ||
} | ||
await runTests(Object.keys(changedPackages)); | ||
} | ||
|
||
/** | ||
* Runs `yarn test` in all dirs in pathList. | ||
* @param {Array<string>} pathList | ||
*/ | ||
async function runTests(pathList) { | ||
if (!pathList) return; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. May be log this case: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good idea, added it to |
||
for (const testPath of pathList) { | ||
try { | ||
await spawn('yarn', ['--cwd', testPath, 'test'], { | ||
stdio: 'inherit' | ||
}); | ||
} catch (e) { | ||
throw new Error(`Error running tests in ${testPath}.`); | ||
} | ||
} | ||
} | ||
|
||
/** | ||
* These are short, always run them. | ||
*/ | ||
async function runIntegrationTests() { | ||
await runTests([ | ||
'integration/browserify', | ||
'integration/firebase-typings', | ||
'integration/typescript', | ||
'integration/webpack' | ||
]); | ||
} | ||
|
||
async function main() { | ||
try { | ||
await runIntegrationTests(); | ||
await runTestsOnChangedPackages(); | ||
} catch (e) { | ||
console.error(e); | ||
process.exit(1); | ||
} | ||
} | ||
|
||
main(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, also fixed this in the template that auto-adds the license headers.