Skip to content

Remove Logger from performance backend log use case #2460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 23, 2019
Merged

Remove Logger from performance backend log use case #2460

merged 7 commits into from
Dec 23, 2019

Conversation

hsubox76
Copy link
Contributor

In preparation for some changes to Logger that will open up some methods to users, we should remove it from this internal use case that doesn't make use of any of Logger's functionality anyway.

@hsubox76 hsubox76 mentioned this pull request Dec 19, 2019
Merged
Feiyang1
Feiyang1 approved these changes Dec 20, 2019
View reviewed changes
alikn
alikn approved these changes Dec 21, 2019
View reviewed changes
@hsubox76 hsubox76 merged commit e4d0455 into master Dec 23, 2019
@hsubox76 hsubox76 added this to the next milestone Jan 7, 2020
@hsubox76 hsubox76 deleted the ch-perflog branch January 8, 2020 21:20
@firebase firebase locked and limited conversation to collaborators Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@alikn alikn alikn approved these changes

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@hsubox76 @Feiyang1 @alikn