Reject with indexeddb errors in RemoteConfig.fetch() #2381
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
await this._storageCache.setLastFetchStatus(lastFetchStatus);
in the catch block can fail (e.g. in envs where indexeddb is not available), but the caller can't catch it because we don't catch it and the program just throws.Refactored the code to use
async await
directly instead of wrapping fetch inside a Promise callback, so all errors will be caught and rejected properly.An alternative considered is to
try catch
in thecatch
block, thenreject
, but it makes the code more complicated and less readable.It fixes #2373 (comment).