Compile time asserts #2367
Merged
Compile time asserts #2367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feiyang1
reviewed
Nov 18, 2019
| @@ -43,7 +43,7 @@ export function fail(failure: string): never { | |||
| * Fails if the given assertion condition is false, throwing an Error with the | |||
| * given message if it did. | |||
| */ | |||
| export function assert(assertion: boolean, message: string): void { | |||
| export function assert(assertion: boolean, message: string): asserts assertion { | |||
Feiyang1
approved these changes
Nov 18, 2019
mikelehen
approved these changes
Nov 18, 2019
There was a problem hiding this comment.
AMAZING!!!
For your next trick you can go through and fix all the places I made people explicitly do:
if (foo instanceof Foo) {
// use foo as Foo
} else {
fail(...)
}
For the sake of type-narrowing! 😛
(just joking, but we should probably keep an eye towards cleaning those up over time)
| const version = this.fromVersion(doc.found!.updateTime!); | ||
| return new Document(key, version, {}, undefined, doc.found!, v => | ||
| assertPresent(doc.found.name, 'doc.found.name'); | ||
| assertPresent(doc.found.updateTime, 'doc.found.updateTime'); |
There was a problem hiding this comment.
Feel free to punt, but could we magic up assertPresent() to get rid of the remaining ! usage below?
There was a problem hiding this comment.
Updated. Do you want to take another look?
schmidt-sebastian
requested review from
hiranya911 and
hsubox76
as code owners
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.