Skip to content

rxfire: objectVal bugfix #2352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2019
Merged

rxfire: objectVal bugfix #2352

merged 1 commit into from
Nov 22, 2019

Conversation

jhuleatt
Copy link
Contributor

Fixing a bug where RxFire's objectVal will return an empty object if the result of snapshot.val() is not an object. For example:

database data:

{
    "counter": 7
}

code:

fromRef(firebase.database().ref('counter')).pipe(value => console.log(value));

logs {} instead of the expected 7.

Copy link
Member

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jhuleatt jhuleatt merged commit 638aba6 into master Nov 22, 2019
@hsubox76 hsubox76 added this to the 7.5.1 milestone Dec 10, 2019
@firebase firebase locked and limited conversation to collaborators Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants