Update @firebase/testing to use component framework #2340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feiyang1
requested review from
ryanpbrewster,
scottcrossen and
yuchenshi
as code owners
yuchenshi
approved these changes
Nov 8, 2019
Feiyang1
force-pushed
the
fei-component-integration
branch
from
bb43a7e to
5e4f80b
Compare
Feiyang1
force-pushed
the
fei-component-testing
branch
from
de3c3a5 to
cc79543
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
go/firebase-js-platform
#2316 implements the proposal.
@firebase/testingis affected by this change.Changes
This PR updates
@firebase/testingto use the component platform implemented in #2316