-
Notifications
You must be signed in to change notification settings - Fork 938
Add support for Typescript Custom Mapping #2240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 36 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
eff1d9b
working with generics fully implemented, no tests
f46af07
[AUTOMATED]: Prettier Code Styling
fb566cf
round 1 schmidt comments
c5d8a5f
[AUTOMATED]: Prettier Code Styling
aed17d1
resolve gil comments, no parent behavior
ea737f9
updated tests and fixed converterFromArgs
d6c6355
Merge branch 'master' into bc/generics
e2b67b3
add more default generic for compiling
7c150db
[AUTOMATED]: Prettier Code Styling
3f9bc7c
working with test + don't always pass converter
6fc432f
Merge branch 'master' into bc/generics
3096f4b
updated to withConverter, needs test cleanup
42297c6
[AUTOMATED]: Prettier Code Styling
338c876
change documentSnapshot methods to <unknown>
7c3c509
Merge branch 'master' into bc/generics
d02d5b4
remove unneeded code, added tests
90138b1
[AUTOMATED]: Prettier Code Styling
f571f6f
add comments to withConverter
e351bc8
Merge branch 'master' into bc/generics
12b602b
[AUTOMATED]: Prettier Code Styling
2dd8945
resolved comments, need to update jsdoc
95340bd
Merge branch 'master' into bc/generics
ba1d7ff
Merge branch 'bc/generics' of github.com:firebase/firebase-js-sdk int…
a03e009
add comment
877b3d0
[AUTOMATED]: Prettier Code Styling
84ebd0b
Merge branch 'master' into bc/generics
fef36eb
resolve comments from michael pt. 2
3abad69
Merge branch 'master' into bc/generics
2ecf3f8
add comment for toString() comparison
f79041c
remove defaultDocumentdataConverter, add readonly access, update comm…
6034dae
[AUTOMATED]: Prettier Code Styling
3c3dbca
add periods to param comments in index.d.ts
0fce460
remove toString() check in isEqual()
ab90ea7
change <unknown> to any, resolve sebastian's comments
b652bf9
[AUTOMATED]: Prettier Code Styling
a0b0975
add changelog
2627c4d
change database.ts back to unknown, update changelog
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.