Skip to content

Fixing Document.toString() #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 12, 2019
Merged

Fixing Document.toString() #2168

merged 2 commits into from
Sep 12, 2019

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Sep 11, 2019 •
edited
Loading

This broke when data became data() in #2115

@schmidt-sebastian
Fixing Document.toString()
26f0156 
This broke when data became data() in #2115
var-const
var-const approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@var-const var-const left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have a test?

@schmidt-sebastian
Copy link
Contributor Author

Should this have a test?

Hmm. Maybe. I'll add one if anyone else chimes in :)

@schmidt-sebastian schmidt-sebastian merged commit 20e8a07 into master Sep 12, 2019
@schmidt-sebastian schmidt-sebastian deleted the schmidt-sebastian-patch-2 branch September 12, 2019 17:30
@firebase firebase locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@var-const var-const var-const approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schmidt-sebastian @var-const