Index-Free: Filter document queries by read time #2159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
changed the title
mikelehen
approved these changes
Sep 6, 2019
| ); | ||
| await cache.addEntries( | ||
| [doc('b/new', 2, DOC_DATA)], | ||
| /* readTime= */ version(1) |
There was a problem hiding this comment.
Reading versions that haven't been written yet! Impressive.
(I assume this is intentional, though I'm also not sure it's a valuable test. I can't immediately think of a bug that this test would catch that the previous one wouldn't).
There was a problem hiding this comment.
Yeah, this might have been more valuable on Android since I switched the implementation from updateTime to readTime. I'll keep it for consistency.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to getAllDocumentsMatchingQuery() to skip documents older than a given update time. This allows us to only scan for documents that have been modified since the Query's Target Mapping has been persisted.
Port of firebase/firebase-android-sdk#617