Skip to content

Add ts-ignore line to allow test:node:persistence to compile #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2019

Conversation

thebrianchen
Copy link

@thebrianchen thebrianchen commented Jul 15, 2019

Will add node:persistence tests after they are running against emulator

@thebrianchen thebrianchen requested a review from wilhuff July 15, 2019 17:58
@thebrianchen thebrianchen changed the title Add ts-ignore line to allow test:node:persistence to compile Add node persistence tests to CI Jul 15, 2019
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thebrianchen thebrianchen changed the title Add node persistence tests to CI Add ts-ignore line to allow test:node:persistence to compile Jul 15, 2019
@thebrianchen thebrianchen merged commit 3c8f85d into master Jul 15, 2019
@thebrianchen thebrianchen deleted the bc/dbshim branch July 15, 2019 22:36
@firebase firebase locked and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants