Fix FirebaseApp overwriting FirebaseError name field #1911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmermerkaya
approved these changes
Jun 25, 2019
There was a problem hiding this comment.
I'm not sure why we want the template parameters in the FirebaseError, so maybe we don't need it anyway?
I'm actually using them for error handling in Installations, to do things like "delete FID if the server returned 404".
BTW, if you write "Fixes #1891" in this format in the description or the commit message, the issue will automatically get marked as fixed when you submit the PR.
hsubox76
approved these changes
Jun 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1891,
but as a long term solution for avoid overwriting fields in FirebaseError, we should create a separate field to hold the template parameters. Since it's a potential breaking change, we will wait for the next major version to change it.
I'm not sure why we want the template parameters in the FirebaseError, so maybe we don't need it anyway?