Fix packages/firestore/ usages of @ts-ignore. #1882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I left the equality_matcher.ts ones for the code we copy/pasted in, but fixed the rest.
schmidt-sebastian
approved these changes
Jun 14, 2019
| @@ -244,8 +244,7 @@ export class WebChannelConnection implements Connection { | |||
| // ReactNative and so we exclude it, which just means ReactNative may be | |||
| // subject to the extra network roundtrip for CORS preflight. | |||
| if (!isReactNative()) { | |||
| // @ts-ignore | |||
| request['httpHeadersOverwriteParam'] = '$httpHeaders'; | |||
| (request as Indexable)['httpHeadersOverwriteParam'] = '$httpHeaders'; | |||
There was a problem hiding this comment.
I wasted more time on this then I should have, but here you go:
interface WebChannelOptions {
messageHeaders?:StringMap;
initMessageHeaders?:StringMap;
messageContentType?:string;
messageUrlParam?:StringMap;
clientProtocolHeaderRequired?:boolean;
concurrentRequestLimit?:number;
supportsCrossDomainXhr?:boolean;
testUrl?:string;
sendRawJson?:boolean;
httpSessionIdParam?:string;
httpHeadersOverwriteParam?:string;
backgroundChannelTest?:boolean;
forceLongPolling?:boolean;
fastHandshake?:boolean;
disableRedac?:boolean;
clientProfile?:string;
internalChannelParams:{[key:string]:boolean|number};
xmlHttpFactory:unknown;
requestRefreshThresholds:{[key:string]:number};
}
const request: WebChannelOptions;
This is based on https://cs.corp.google.com/piper///depot/google3/javascript/closure/labs/net/webchannel.js?rcl=242544058&l=196
|
@hsubox76 If you're okay with this, I'll merge it into your PR. |
hsubox76
approved these changes
Jun 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I left the equality_matcher.ts ones for the code we copy/pasted in, but fixed the rest.
The most controversial change is introducing
@Indexableas a type alias for{[k: string]: unknown}and casting to it in a few places. I could alternatively just cast directly to{[k: string]: unknown}orany(with ts-lint ignore comment) in those places...cc/ @hsubox76 FYI. I'll assign this to you once @schmidt-sebastian signs off.