Skip to content

point ENVIRONMENTS.md to devsite #1772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2019
Merged

point ENVIRONMENTS.md to devsite #1772

merged 2 commits into from
May 10, 2019

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented May 9, 2019

No description provided.

@mmermerkaya
Copy link
Contributor

Can we put this in README instead, and delete this file?

@hsubox76
Copy link
Contributor

hsubox76 commented May 9, 2019

Seems like a good idea to put in README.md unless there are links to this page from somewhere or there is a convention for people to check for a file with this name.

@mmermerkaya
Copy link
Contributor

Not sure about links to the file, but I'm pretty sure that there's no such convention. And I know that at least one user didn't notice the file 🙂 #880 (comment)

@Feiyang1
Copy link
Member Author

Feiyang1 commented May 9, 2019

Moved the section to README

@mmermerkaya
Copy link
Contributor

BTW, I think this PR fixes #914.

@Feiyang1
Copy link
Member Author

Feiyang1 commented May 9, 2019

Yay! One more closed issue.

@Feiyang1 Feiyang1 merged commit 9f6dbc8 into master May 10, 2019
@Feiyang1 Feiyang1 deleted the fei-env branch May 10, 2019 20:22
@firebase firebase locked and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants