Skip to content

add clearPersistence() to index.d.ts #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 5, 2019
Merged

add clearPersistence() to index.d.ts #1717

merged 15 commits into from
Jun 5, 2019

Conversation

thebrianchen
Copy link

Using this PR as a draft to get the correct description for clearPersistence().

@thebrianchen thebrianchen requested a review from wilhuff April 22, 2019 22:50
@thebrianchen thebrianchen assigned wilhuff and unassigned wilhuff Apr 23, 2019
wilhuff
wilhuff reviewed Apr 23, 2019
View reviewed changes
@wilhuff wilhuff assigned thebrianchen and unassigned wilhuff Apr 23, 2019
wilhuff
wilhuff approved these changes Apr 24, 2019
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Don't merge until we get approval.

@wilhuff wilhuff removed their assignment Apr 29, 2019
@thebrianchen thebrianchen requested a review from Feiyang1 April 30, 2019 18:52
@thebrianchen thebrianchen requested a review from yuchenshi as a code owner May 24, 2019 22:31
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@thebrianchen thebrianchen requested a review from wilhuff June 5, 2019 01:45
@thebrianchen thebrianchen assigned wilhuff and unassigned Feiyang1 and thebrianchen Jun 5, 2019
wilhuff
wilhuff reviewed Jun 5, 2019
View reviewed changes
@thebrianchen thebrianchen merged commit 7a15e7e into master Jun 5, 2019
@thebrianchen thebrianchen deleted the bc/cp-docu branch June 5, 2019 18:55
wilhuff
wilhuff approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@firebase firebase locked and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@wilhuff wilhuff wilhuff approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees

@wilhuff wilhuff

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thebrianchen @googlebot @Feiyang1 @wilhuff