Skip to content

[DO NOT SUBMIT] Add more logging to abort. #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[DO NOT SUBMIT] Add more logging to abort. #1649

wants to merge 1 commit into from

Conversation

mikelehen
Copy link
Contributor

Not for submission. Just suggesting this to possibly help debug #1642

@mikelehen mikelehen mentioned this pull request Mar 29, 2019
Closed
larssn
larssn reviewed Apr 11, 2019
View reviewed changes
packages/firestore/src/local/simple_db.ts
@@ -312,7 +314,8 @@ export class SimpleDbTransaction {
this.transaction.oncomplete = () => {
this.completionDeferred.resolve();
};
this.transaction.onabort = () => {
this.transaction.onabort = (event) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? event is not getting used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that could be reverted... I was just hacking this together real quick and am not planning to submit it as-is. 😄

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, just wanted to be sure where you'd want the error from. 😅

I'm pushing a new release with your suggestions here; so we should have some kind of data fairly soon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, fantastic! I think while writing this I was wondering the same thing (if there was error information in the event) but discovered that there was not.

@zijianjoy zijianjoy force-pushed the mikelehen/abort-logging branch from 8b4f151 to 65b3f5f Compare May 24, 2019 22:31
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@wilhuff wilhuff force-pushed the mikelehen/abort-logging branch from 65b3f5f to 8b4f151 Compare May 25, 2019 01:15
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@mikelehen mikelehen closed this Mar 29, 2020
@firebase firebase locked and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@larssn larssn larssn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikelehen @googlebot @larssn