Treat ABORTED writes as retryable #1456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilhuff
requested review from
rsgowman,
schmidt-sebastian,
var-const and
zxu123
as code owners
mikelehen
approved these changes
Jan 8, 2019
|
I looked at the transaction code too. While our current handling seems specious there I think addressing that is out of scope for this change. I've addressed the test failure by adding |
wilhuff
added a commit
to firebase/firebase-ios-sdk
that referenced
this pull request
Jan 10, 2019
This is a port of firebase/firebase-js-sdk#1456.
wilhuff
added a commit
to firebase/firebase-ios-sdk
that referenced
this pull request
Jan 11, 2019
* Treat ABORTED writes as retryable This is a port of firebase/firebase-js-sdk#1456. * Regenerate spec test json
wilhuff
added a commit
to firebase/firebase-android-sdk
that referenced
this pull request
Jan 11, 2019
This corresponds to a server-side change that will be released for the v1 protocol only (see b/119437764). This is a port of firebase/firebase-js-sdk#1456.
wilhuff
added a commit
to firebase/firebase-android-sdk
that referenced
this pull request
Jan 11, 2019
This corresponds to a server-side change that will be released for the v1 protocol only (see b/119437764). This is a port of firebase/firebase-js-sdk#1456.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corresponds to a server-side change that will be released for the v1 protocol only.