Skip to content

Update grpc to 1.16.1 to support node 11 #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Conversation

sunnylqm
Copy link
Contributor

Need to update grpc dependency to 1.16.1 to support node 11 according to grpc/grpc-node#594 (comment)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@sunnylqm
Copy link
Contributor Author

Just signed cla

@googlebot
Copy link

CLAs look good, thanks!

@mikelehen
Copy link
Contributor

Thanks! Could you also update it in packages/functions and then re-run yarn from the root to update our yarn.lock file?

@LiteSoul
Copy link

Patiently waiting for Node 11 support 🙏

@mikelehen mikelehen assigned Feiyang1 and unassigned mikelehen Nov 29, 2018
@mikelehen
Copy link
Contributor

LGTM. @Feiyang1 feel free to merge.

@Feiyang1 Feiyang1 merged commit 603cf63 into firebase:master Nov 30, 2018
@firebase firebase locked and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants