Fix waitsForCount in EventAccumulator (tests) #1378
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
waitsForCount(count)
helper function for the tests of the realtime database returns anEventAccumulator
that is supposed to wait forcount
events to happen before resolving its Promise.The current implementation, though, always resolves its Promise after the very first event no matter how many were specified. This could lead to tests behaving erroneously.
A quick demo to verify this incorrect behavior:
This outputs the following:
When it should output this:
This PR fixes this. I've rerun all the tests in the database package after the change and they all keep passing, so I guess we got lucky ¯\_(ツ)_/¯