Throw a more helpful error if there isn't a 'sub' field #1366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonymeng
approved these changes
Nov 8, 2018
Feiyang1
pushed a commit
that referenced
this pull request
Nov 9, 2018
* Throw a more helpful error if there isn't a 'sub' field * fix test
zijianjoy
pushed a commit
that referenced
this pull request
May 24, 2019
* Throw a more helpful error if there isn't a 'sub' field * fix test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if you try
firebase.initializeTestApp({ ..., auth: { "email": "[email protected]" })it will be rejected in the emulator because we require asubfield. This happens silently and is pretty confusing. I think we should blow up immediately in the client, so developers can figure out what they're doing wrong.