Skip to content

Merge LRU tracking PRs #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 4, 2018
Merged

Merge LRU tracking PRs #1285

merged 6 commits into from
Oct 4, 2018

Conversation

gsoltis
Copy link

@gsoltis gsoltis commented Oct 4, 2018

This PR includes 3 already reviewed PRs:

#1224 IndexedDB LRU Reference Delegate
#1237 Memory LRU Reference Delegate
#1256 Memory Eager Reference Delegate

The last one includes removing the old garbage collector and fixing up tests.

The other commits are me trying to merge master and only messing it up a little.

Greg Soltis added 6 commits September 19, 2018 11:46
Implement IndexedDB LRU Reference Delegate, add LRU tests
* Implement lru reference delegate for memory persistence
Merging master into lru branch
#1256)

* Implement eager reference delegate for memory

* Removing old garbage collector and fixing tests

* Remove sequential forEach, replace with parallel forEach
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To quote our Kirkland based team: Yolo.

@gsoltis gsoltis merged commit dd3ea8f into master Oct 4, 2018
@gsoltis gsoltis deleted the lru-master branch October 4, 2018 21:36
@firebase firebase locked and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants