Backfill Firestore Changelog #1275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
requested review from
gsoltis,
mikelehen,
rsgowman,
var-const,
wilhuff and
zxu123
as code owners
wilhuff
approved these changes
Oct 2, 2018
| # Unreleased | ||
|
|
||
| # 0.8.2 | ||
| - [fixed] Fixed an issue where native ES6 module loading was not working. |
There was a problem hiding this comment.
Is it worth mentioning webchannel in this at all?
There was a problem hiding this comment.
I just used the public release notes.
mikelehen
reviewed
Oct 2, 2018
| - [fixed] Fixed an issue where native ES6 module loading was not working. | ||
|
|
||
| # 0.8.1 | ||
| - [fixed] Fixed an issue where typings are created in the wrong location. |
There was a problem hiding this comment.
Is there a way to rephrase this somehow to represent a user-visible difference in the SDK? This seems to be describing the cause of the issue rather than the symptom. Also "are" should be "were" to match the tense of "fixed"
There was a problem hiding this comment.
Leaving as is since this matches the public release notes.
|
BTW, this just copies the existing Firestore entries from https://firebase.google.com/support/release-notes/js |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.