Allow iterables in PersistencePromise.map/forEach/waitFor #1269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
requested review from
gsoltis,
mikelehen,
rsgowman,
var-const,
wilhuff and
zxu123
as code owners
| return results; | ||
| }); | ||
| return PersistencePromise.forEach(all, result => { | ||
| results.push(result); |
There was a problem hiding this comment.
I think this should append the elements in the correct order since forEach waits for each promise one by one...
mikelehen
approved these changes
Oct 1, 2018
gsoltis
approved these changes
Oct 1, 2018
|
We install polyfills for Symbol.iterator: import 'core-js/fn/array/find'; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revived this PR since #1256 could benefit from it.
This allows us to use SortedSet and SortedMap in the PersistencePromise utilities.