Skip to content

Update test comments #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2018
Merged

Update test comments #1247

merged 1 commit into from
Sep 25, 2018

Conversation

schmidt-sebastian
Copy link
Contributor

  1. Remove "held writes" from the spec tests name
  2. Update comment for one of the tests to explain why it really needs eager-gc

@schmidt-sebastian schmidt-sebastian mentioned this pull request Sep 24, 2018
Merged
@schmidt-sebastian schmidt-sebastian merged commit 9d81810 into master Sep 25, 2018
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt-testcomments branch October 2, 2018 16:59
@basvdijk basvdijk mentioned this pull request Oct 5, 2018
Closed
@firebase firebase locked and limited conversation to collaborators Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gsoltis gsoltis gsoltis approved these changes

@mikelehen mikelehen Awaiting requested review from mikelehen

@rsgowman rsgowman Awaiting requested review from rsgowman

@var-const var-const Awaiting requested review from var-const

@wilhuff wilhuff Awaiting requested review from wilhuff

@zxu123 zxu123 Awaiting requested review from zxu123

Assignees
No one assigned
Labels
needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @gsoltis @google-oss-bot