Skip to content

Using SortedSet instead of a PriorityQueue #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 19, 2018
Merged

Using SortedSet instead of a PriorityQueue #1233

merged 6 commits into from
Sep 19, 2018

Conversation

gsoltis
Copy link

@gsoltis gsoltis commented Sep 18, 2018

As discussed, here's the implementation of RollingSequenceNumberBuffer with a SortedSet.

Note that merge base is the current lru PR: #1224

@gsoltis gsoltis requested a review from mikelehen September 18, 2018 17:09
mikelehen
mikelehen approved these changes Sep 19, 2018
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a fan of this. WDYT?

@mikelehen mikelehen assigned gsoltis and unassigned mikelehen Sep 19, 2018
gsoltis
gsoltis commented Sep 19, 2018
View reviewed changes
Copy link
Author

@gsoltis gsoltis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's fine. If it becomes an issue, it's a pretty easy component to swap out. I'll merge this to the other PR.

@gsoltis gsoltis merged commit 34f62fb into gsoltis/indexeddb_lru Sep 19, 2018
@gsoltis gsoltis deleted the gsoltis/sorted_set_lru branch September 19, 2018 16:40
@firebase firebase locked and limited conversation to collaborators Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikelehen mikelehen mikelehen approved these changes

@rsgowman rsgowman Awaiting requested review from rsgowman

@schmidt-sebastian schmidt-sebastian Awaiting requested review from schmidt-sebastian

@var-const var-const Awaiting requested review from var-const

@wilhuff wilhuff Awaiting requested review from wilhuff

@zxu123 zxu123 Awaiting requested review from zxu123

Assignees

@gsoltis gsoltis

Labels
needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsoltis @mikelehen @google-oss-bot