Shallowing up the Typescript surface for firebase/app and exporting default #1184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesdaniels
requested review from
bojeil-google,
depoll,
hiranya911 and
mikelehen
as code owners
|
@jshcrowthe @davideast I'm not sure if this is 100% the correct / complete answer, but this is how I was able to get things working well locally. Happy to discuss further. |
jamesdaniels
changed the title
jamesdaniels
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import firebase from 'firebase/app'fails for Typescript developers, but is needed for correct behavior on both browser and Node asimport * as firebase from 'firebase/app'ends up with an entirely different object in Node.The core of the matter is the types as they stand suggest that
firebase/appis a CJS/AMD, when we're actually an ESM+CJS with a default export. Therefore shallowing up, exporting each namespace individually, and exporting a default namespace is more correct.As far as I'm aware this is not a breaking change.