Skip to content

Escape the persistence key everywhere & scope online state by project #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2018
Merged

Escape the persistence key everywhere & scope online state by project #1182

merged 1 commit into from
Aug 31, 2018

Conversation

schmidt-sebastian
Copy link
Contributor

This PR fixes some issues in SharedClientState:

  • It used the escapedPersistenceKey everywhere instead of the unescaped version.
  • It scopes online state by Firebase App (persistence key). This is needed since only tabs that share the same persistence key communicate through multi-tab.

@schmidt-sebastian schmidt-sebastian merged commit ac7f9ce into master Aug 31, 2018
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt-escapeandnamespaceonlinekey branch September 5, 2018 18:22
@firebase firebase locked and limited conversation to collaborators Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gsoltis gsoltis gsoltis approved these changes

@mikelehen mikelehen Awaiting requested review from mikelehen

@rsgowman rsgowman Awaiting requested review from rsgowman

@var-const var-const Awaiting requested review from var-const

@wilhuff wilhuff Awaiting requested review from wilhuff

@zxu123 zxu123 Awaiting requested review from zxu123

Assignees
No one assigned
Labels
needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @gsoltis @google-oss-bot