Change removeMutationBatch to remove a single batch #1148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
force-pushed
the
mrschmidt-removemutationbatch
branch
from
c172a19 to
c637f67
Compare
wilhuff
approved these changes
Aug 20, 2018
| if (startIndex === 0) { | ||
| for (; queueIndex < queueCount; queueIndex++) { | ||
| if (batchIndex === 0) { | ||
| let queueIndex = 1; |
There was a problem hiding this comment.
endIndex? The queueIndex name was never any good and now it's even worse because we're not comparing the batch to remove against the queue contents.
| mutation.key.path, | ||
| batch.batchId | ||
| ); | ||
| this.removeCachedMutationKeys(batch.batchId); |
There was a problem hiding this comment.
Why is this called in the loop? Couldn't this be called outside the loop on mutations in the batch?
There was a problem hiding this comment.
Yeah, this should just be called once. Fixed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to make #1135 smaller and extracts the refactor that changes
removeMutationBatchestoremoveMutationBatch, which only accepts a single batch at a time.