Adding back callback assert #1081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
... and I have also make "keepInQueue" optional. It defaults to false, which reduces the diff of the JSON against master. |
schmidt-sebastian
force-pushed
the
multitab-addbackcallbackassert
branch
2 times, most recently
from
a51fd41 to
2ba8368
Compare
schmidt-sebastian
force-pushed
the
multitab-addbackcallbackassert
branch
from
2ba8368 to
3f3d7ec
Compare
|
Android Port of these changes: https://github.com/FirebasePrivate/firebase-android-sdk/pull/167 |
mikelehen
approved these changes
Aug 2, 2018
| @@ -645,7 +645,7 @@ describeSpec('Writes:', [], () => { | |||
| expectRequestCount({ handshakes: 2, writes: 2, closes: 1 }) | |||
| ) | |||
| .expectNumOutstandingWrites(1) | |||
| .writeAcks('collection/key', 1, { expectUserCallback: false }) | |||
There was a problem hiding this comment.
Was this a bug before? Else I'm confused why this changed since the default is true, right? So omitting it is a change in behavior...
There was a problem hiding this comment.
Yeah, this was wrong. Disabling and re-enabling the network should not affect whether we resolve the user callback. This now fails since I am asserting that I didn't get any unexpected write acknowledgments.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current spec tests in multi-tab don't verify the ackWrite/failWrite callbacks by default. This fixes this regression.