[Multi-Tab] Don't add change log entry when there are no changes #1051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelehen
approved these changes
Jul 26, 2018
| let changedKeys = documentKeySet(); | ||
| for (const maybeDocument of maybeDocuments) { | ||
| if (maybeDocuments.length > 0) { | ||
| const documentStore = remoteDocumentsStore(transaction); |
There was a problem hiding this comment.
This seems fine... but why are we calling addEntries() with an empty list anyway? Should we be filtering this out at a higher-level (potentially preventing even more unnecessary work?
There was a problem hiding this comment.
I was pondering about doing this one layer up, but ended up picking the remote_document_cache for no particular reason (other than this would solve the same problem no matter who calls addEntries). Leaving as is.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FriendlyEats writes a bunch of empty change events to the document change log. Let's not do that.