feat(auth): Adds support to specifying Auth state persistence. #105
Conversation
fix(auth): Adds missing phoneNumber property in UserInfo. fix(auth): Fixes incorrect return type in reauthenticateAndRetrieveDataWithCredential.
| @@ -480,7 +487,7 @@ firebase.User.prototype.reauthenticateWithCredential = function(credential) {}; | |||
| * </dl> | |||
| * | |||
| * @param {!firebase.auth.AuthCredential} credential | |||
| * @return {!firebase.Promise<void>} | |||
| * @return {!firebase.Promise<!firebase.auth.UserCredential>} | |||
There was a problem hiding this comment.
This same change should be made in the typings.
There was a problem hiding this comment.
Typings were autoimported from externs (same for below)
| * @enum {string} | ||
| * An enumeration of the possible persistence mechanism types. | ||
| */ | ||
| firebase.auth.Auth.Persistence = { |
There was a problem hiding this comment.
Same here, this should also be in the typings.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
There was a problem hiding this comment.
The externs all look solid. I have also included the generated typings and imported source into this branch. @bojeil-google PTAL
Defines externs for new API to specify Auth state persistence.
fix(auth): Adds missing phoneNumber property in UserInfo.
fix(auth): Fixes incorrect return type in reauthenticateAndRetrieveDataWithCredential.