Skip to content

[Multi-Tab] Sort the initial set of changes #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2018

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Jul 26, 2018

The new fromInitialDocuments didn't respect the query order as it went through DocumentChangeSet. I changed this back to what event manager was doing and added a spec test that verified query result order.

Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the test!

@schmidt-sebastian schmidt-sebastian merged commit 2e5a7ab into firestore-multi-tab Jul 26, 2018
@schmidt-sebastian schmidt-sebastian deleted the multitab-initialorder branch August 3, 2018 17:15
@firebase firebase locked and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants