Skip to content

Refactor PersistentStream. #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 30, 2018
Merged

Refactor PersistentStream. #1041

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
530406f
Refactor PersistentStream.
Jul 12, 2018
26a1fc2
CR feedback: Rework assert for stopping necessary streams.
Jul 26, 2018
54a78ca
CR feedback: Rework callback invalidation with stateSequenceNumber.
Jul 26, 2018
ac74c0e
CR feedback: closeGuardedDispatcher
Jul 28, 2018
126d8ee
CR feedback: Clear writePipeline any time network is disabled.
Jul 28, 2018
5bab890
Merge branch 'master' into mikelehen/stream-state-rework
Jul 28, 2018
6c2393c
CR feedback (redundant set of lastStreamToken, formatting, naming)
Jul 30, 2018
6b47b51
Merge branch 'master' into mikelehen/stream-state-rework
mikelehen Jul 30, 2018
82ba6fe
Merge branch 'master' into mikelehen/stream-state-rework
mikelehen Jul 30, 2018
e2ca11c
Merge branch 'master' into mikelehen/stream-state-rework
mikelehen Jul 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions packages/firestore/src/remote/datastore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { WatchStreamListener, WriteStreamListener } from './persistent_stream';
/**
* Copyright 2017 Google Inc.
*
Expand Down Expand Up @@ -54,21 +55,27 @@ export class Datastore {
private serializer: JsonProtoSerializer
) {}

newPersistentWriteStream(): PersistentWriteStream {
newPersistentWriteStream(
listener: WriteStreamListener
): PersistentWriteStream {
return new PersistentWriteStream(
this.queue,
this.connection,
this.credentials,
this.serializer
this.serializer,
listener
);
}

newPersistentWatchStream(): PersistentListenStream {
newPersistentWatchStream(
listener: WatchStreamListener
): PersistentListenStream {
return new PersistentListenStream(
this.queue,
this.connection,
this.credentials,
this.serializer
this.serializer,
listener
);
}

Expand Down
Loading