Skip to content

usePublicVapidKey not defined in firebase.messaging namespace, causing build error #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jenperson opened this issue Mar 14, 2018 · 2 comments

Comments

@jenperson
Copy link

[REQUIRED] Describe your environment

  • Operating System version: Mac OS 10.13.3
  • Firebase SDK version: 10.4.1
  • Firebase Product: Messaging (auth, database, storage, etc)

[REQUIRED] Describe the problem

Steps to reproduce:

Steps to Reproduce the bug:

  1. Set up Firebase web app using Typescript for FCM
  2. Try to call messaging.usePublicVapidKey("key_here1234");
  3. Get error: [ts] Property 'usePublicVapidKey' does not exist on type 'Messaging'.

Relevant Code:

Define usePublicVapidKey in firebase.messaging namespace
https://github.com/firebase/firebase-js-sdk/blob/master/packages/firebase/index.d.ts#L464

@abeisgoat
Copy link
Contributor

Looks like it's declared correctly in @firebase/types-messaging but didn't make it to the firebase package's index.d.ts so we just need to move that over.

@jshcrowthe
Copy link
Contributor

Thanks for the report @jenperson and the fix @AbeHaskins this'll go out in the next release 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants