resolve gil comments

Author: Brian Chen

.changeset/wicked-cups-search.md

@@ -2,4 +2,4 @@
 '@firebase/firestore': minor
 ---
 
-Removed validation of `null` and `NaN` values in filters. However, note that only `==` and `!=` filters match against `null` and `NaN`.
+Removed excess validation of null and NaN values in query filters. This more closely aligns the SDK with the Firestore backend, which has always accepted null and NaN for all operators, even though this isn't necessarily useful.

packages/firestore/test/integration/api/query.test.ts

@@ -818,9 +818,19 @@ apiDescribe('Queries', (persistence: boolean) => {
       const snapshot3 = await coll.where('zip', 'in', [null]).get();
       expect(toDataArray(snapshot3)).to.deep.equal([]);
 
+      // With null and a value.
+      const snapshot4 = await coll.where('zip', 'in', [98101, null]).get();
+      expect(toDataArray(snapshot4)).to.deep.equal([{ zip: 98101 }]);
+
       // With NaN.
-      const snapshot4 = await coll.where('zip', 'in', [Number.NaN]).get();
-      expect(toDataArray(snapshot4)).to.deep.equal([]);
+      const snapshot5 = await coll.where('zip', 'in', [Number.NaN]).get();
+      expect(toDataArray(snapshot5)).to.deep.equal([]);
+
+      // With NaN and a value.
+      const snapshot6 = await coll
+        .where('zip', 'in', [98101, Number.NaN])
+        .get();
+      expect(toDataArray(snapshot6)).to.deep.equal([{ zip: 98101 }]);
     });
   });
 
@@ -958,15 +968,27 @@ apiDescribe('Queries', (persistence: boolean) => {
 
       // With null.
       const snapshot3 = await coll
-        .where('zip', 'array-contains-any', [null])
+        .where('array', 'array-contains-any', [null])
         .get();
       expect(toDataArray(snapshot3)).to.deep.equal([]);
 
-      // With NaN.
+      // With null and a value.
       const snapshot4 = await coll
-        .where('zip', 'array-contains-any', [Number.NaN])
+        .where('array', 'array-contains-any', [43, null])
         .get();
-      expect(toDataArray(snapshot4)).to.deep.equal([]);
+      expect(toDataArray(snapshot4)).to.deep.equal([{ array: [43] }]);
+
+      // With NaN.
+      const snapshot5 = await coll
+        .where('array', 'array-contains-any', [Number.NaN])
+        .get();
+      expect(toDataArray(snapshot5)).to.deep.equal([]);
+
+      // With NaN and a value.
+      const snapshot6 = await coll
+        .where('array', 'array-contains-any', [43, Number.NaN])
+        .get();
+      expect(toDataArray(snapshot6)).to.deep.equal([{ array: [43] }]);
     });
   });
 

packages/firestore/test/integration/api/validation.test.ts

@@ -711,14 +711,6 @@ apiDescribe('Validation:', (persistence: boolean) => {
       );
     });
 
-    validationIt(persistence, 'enum', db => {
-      const collection = db.collection('test') as any;
-      expect(() => collection.where('a', 'foo' as any, 'b')).to.throw(
-        'Invalid value "foo" provided to function Query.where() for its second argument. ' +
-          'Acceptable values: <, <=, ==, !=, >=, >, array-contains, in, array-contains-any, not-in'
-      );
-    });
-
     it('cannot be created from documents missing sort values', () => {
       const testDocs = {
         f: { k: 'f', nosort: 1 } // should not show up